Open
Conversation
…ps.git into create-fromArray
Member
|
The diff shows a lot of noise (i.e. deletions and additions of the same stuff), mostly introduced by 85ed7b4. Can you rebase the branch on master and force push to clean up the history? |
Contributor
|
@Xanthorapedia Thank you for your work on these changes! If you could please clean up the git history for this PR, that would be greatly appreciated. As @imagejan noted, there are a couple of commits with a lot of noise. Additionally, there appears to be duplicate commits (i.e. 99652b4 and 65868d9, etc.) and a merge commit which shouldn't be there. Cleaning up the history would make these changes much easier to review, and would help bring the PR closer to a "merge-able" state. Also please check to make sure each commit builds with passing tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates ops that wrap 1-D or 2-D primitive arrays around
ArrayImgorPlanarImgofRealTypes. The ops have been tested with random data to ensure the values and order of the values are as expected. A call to the ops takes the input array (1-D forArrayImgand 2-D forPlanarImgwith each 1-D element representing a plane) and the dimension of the image. If the image pixels are of variable length type, an additional parameter is required to specify the number of bits occupied by each point.The PR is ready for code review.